Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: context cleanup (4/n) #7217

Merged
merged 23 commits into from
Sep 2, 2024
Merged

chore: context cleanup (4/n) #7217

merged 23 commits into from
Sep 2, 2024

Conversation

tac0turtle
Copy link
Member

Description

Remove sdk.Context some more

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@tac0turtle tac0turtle changed the base branch from main to marko/context-capability August 28, 2024 13:53
@tac0turtle tac0turtle changed the title chore: context cleanup (3/n) chore: context cleanup (4/n) Aug 28, 2024
Base automatically changed from marko/context-capability to main August 30, 2024 10:08
@tac0turtle tac0turtle marked this pull request as ready for review August 30, 2024 13:20
damiannolan
damiannolan approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

modules/apps/27-interchain-accounts/host/keeper/migrations.go Outdated
if m.keeper != nil {
params := types.DefaultParams()
if m.keeper.legacySubspace != nil {
m.keeper.legacySubspace.GetParamSetIfExists(ctx, &params)
sdkCtx := sdk.UnwrapSDKContext(ctx) // TODO: should we remove legacy migrations?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, opened #7234

modules/apps/29-fee/keeper/migrations.go Outdated Show resolved Hide resolved
DimitrisJim
DimitrisJim approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again!

@DimitrisJim DimitrisJim added this pull request to the merge queue Sep 2, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
133 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Merged via the queue into main with commit eb51dff Sep 2, 2024
70 checks passed
@DimitrisJim DimitrisJim deleted the marko/context-cleanup3 branch September 2, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@colin-axner colin-axner Awaiting requested review from colin-axner

@chatton chatton Awaiting requested review from chatton

Assignees

@damiannolan damiannolan

@DimitrisJim DimitrisJim

Labels
None yet
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @damiannolan @DimitrisJim